[bitnami/argo-cd] Use http port of service in ingress when insecure flag is set on server #36361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Which port of the ArgoCD server service is used by the ingress is defined by whether or not the server provides an https endpoint and not based on the TLS configuration of the ingress.
Benefits
Bugfix: Some tools and services try to gather the scheme used to communicate with the server from the name and/or port number it communicates with.
Traefik is an example: If you tell Traefik to communicate with a service with name
httpsand/or on port443(through the service config of your Ingress resource), it will try to connect to it with https. If your server does not "speak" https, then you'll end up with a "502 Bad Gateway".There could also be other things with similar problems, like health checks and such.
Even for tools/ingress controllers, that are doing http by default, using a service named https, that actually does plain http makes it harder to understand and has no benefit, in my opinion.
Possible drawbacks
None
Applicable issues
None
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm